fix(svg): apply every namespace in slot when call applyNS #11349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea when we get this? Really need it. |
|
Slots do not render in foreignObjects if the foreignObject is not in the template of the same component that has the root svg element of the svg. Means you can't split svg into components properly. |
posva
changed the title
posva
changed the title
|
What can we do to get this merged in? I really need this fix |
since we output es5, classes are more verbose then necessary
…ructured default value (vuejs#12842) fix vuejs#12841
Using a WeakMap polyfill isn't ideal because the reason we tried to use WeakMap was to work with non-extensible objects. However, WeakMap polyfill for non-extensible objects are non-weak and could lead to memory leaks. The trade-off is that we remove support for `readonly()` on non-extensible objects, which seems reasonable. close vuejs#12837
|
Is this going to get merged in? |
|
Have been waiting for this fix for a long time now. |
zhangzhonghe
force-pushed
the
fix/11315
branch
from
c1dc8d8
to
cf4bcec
Compare
|
I just rebased it on the latest code. I don't know why it makes this big! |
zhangzhonghe
force-pushed
the
fix/11315
branch
2 times, most recently
from
9bc9025
to
72aed6a
Compare
|
See #13008 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11315
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: