fix(keep-alive): fix memory leak without breaking transition tests

vuejs · Dec 7, 2023 · e0747f4 · e0747f4
1 parent 2632249
commit e0747f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/core/components/keep-alive.ts b/src/core/components/keep-alive.ts
@@ -33,10 +33,15 @@ function matches(
 }
 
 function pruneCache(
- keepAliveInstance: { cache: CacheEntryMap; keys: string[]; _vnode: VNode },
+ keepAliveInstance: {
+ cache: CacheEntryMap
+ keys: string[]
+ _vnode: VNode
+ $vnode: VNode
+ },
  filter: Function
 ) {
- const { cache, keys, _vnode } = keepAliveInstance
+ const { cache, keys, _vnode, $vnode } = keepAliveInstance
  for (const key in cache) {
  const entry = cache[key]
  if (entry) {
@@ -46,6 +51,7 @@ function pruneCache(
  }
  }
  }
+ $vnode.componentOptions!.children = undefined
 }
 
 function pruneCacheEntry(

diff --git a/src/core/vdom/create-component.ts b/src/core/vdom/create-component.ts
@@ -62,8 +62,6 @@ const componentVNodeHooks = {
  vnode, // new parent vnode
  options.children // new children
  )
- // #12187 unset children reference after use to avoid memory leak
- options.children = undefined
  },
 
  insert(vnode: MountedComponentVNode) {