perf: improve benchmark test code #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vapor-repl ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for vapor-template-explorer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Size ReportBundles
Usages
|
LittleSound
commented
Aug 17, 2024
Comment on lines
+25
to
+26
| rows.value.push(...buildData(1000)) | ||
| triggerRef(rows) |
There was a problem hiding this comment.
I tested different options for adding items to an existing arrow on jsbench.me. this is the fastest.
LittleSound
commented
Aug 17, 2024
Comment on lines
46
to
51
| const update = wrap('update', () => { | ||
| const _rows = rows.value | ||
| for (let i = 0; i < _rows.length; i += 10) { | ||
| _rows[i].label += ' !!!' | ||
| for (let i = 0, len = _rows.length; i < len; i += 10) { | ||
| _rows[i].label.value += ' !!!' | ||
| } | ||
| setRows() | ||
| }) |
There was a problem hiding this comment.
the time complexity of this update has improved from O(n) to O(n/10)
|
commit: @vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-shared
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
@vue/vapor
|
LittleSound
force-pushed
the
perf/improve-benchmark-test-code
branch
from
e5217c3
to
ed45f05
Compare
LittleSound
commented
Aug 17, 2024
benchmark/client/App.vue
Outdated
Comment on lines
82
to
92
| // Reduce the complexity of `selected` from O(n) to O(1). | ||
| function createSelector(source: WatchSource) { | ||
| const list: Record<keyof any, ShallowRef<boolean>> = {} | ||
| watch(source, (val, old) => { | ||
| if (old != undefined) list[old]!.value = false | ||
| if (val != undefined) list[val]!.value = true | ||
| }) | ||
| return (id: keyof any) => (list[id] ??= shallowRef(false)).value | ||
| } | ||
|
|
||
| const isSelected = createSelector(selected) |
There was a problem hiding this comment.
Reduce the time complexity of this selected from O(n) to O(1).
LittleSound
force-pushed
the
perf/improve-benchmark-test-code
branch
from
91e12cc
to
f25b249
Compare
sxzz
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better for the performance of Vue Vapor, improve the benchmark test code based on the architectural features of Vapor.
I have synchronized these changes to JS Framework Benchmark repo.
In krausest/js-framework-benchmark#1729