Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme-default): Add icons on action buttons #3795

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

0xlau
Copy link
Contributor

@0xlau 0xlau commented Apr 17, 2024

close #3783

Usages

actions:
    - theme: brand
      text: lorem ipsum
      link: https://test.com
      startIcon:
          src: /test.svg
          alt: test
          width: 18
          height: 18

or

actions:
    - theme: brand
      text: lorem ipsum
      link: https://test.com
      endIcon: <svg xmlns="http://www.w3.org/2000/svg" width="1em" height="1em" viewBox="0 0 24 24"><path fill="currentColor" d="m16.172 11l-5.364-5.364l1.414-1.414L20 12l-7.778 7.778l-1.414-1.414L16.172 13H4v-2z"/></svg>

About Docs

interface HeroAction {

  // .....

  // Show the left icon on action button.
  startIcon?: ActionIcon

  // Show the right icon on action button.
  endIcon?: ActionIcon
}

type ActionIcon =
  | string
  | { src: string; alt?: string; width?: string; height: string }
  | {
      light: string
      dark: string
      alt?: string
      width?: string
      height: string
    }

ScreenShot

image

@0xlau 0xlau changed the title feat(default theme): Add icons on action buttons feat(theme-default): Add icons on action buttons Apr 19, 2024
@brc-dd brc-dd added the needs author action The PR is not ready yet label Apr 26, 2024
@0xlau 0xlau requested a review from brc-dd April 27, 2024 05:32
@brc-dd brc-dd removed the needs author action The PR is not ready yet label Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[default theme] Icons on action buttons
2 participants