Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): show progress during render, log duration for each task, use humanized format #3385

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat(build): show progress during render, log duration for each task, use humanized format #3385

wants to merge 13 commits into from

Conversation

zhangyx1998
Copy link
Contributor

@zhangyx1998 zhangyx1998 commented Dec 28, 2023 •
edited

This PR enhances the task() utility by logging the duration after completion of a task. In addition, the build completion message also prints human friendly durations.

In addition, finally statement is used in task.ts to make the code more concise.

This change will allow me to demonstrate the performance improvement in later pull requests regarding parallelisation.

Before:

✓ building client + server bundles ...
✓ rendering pages ...
✓ generating sitemap ...
build complete in 193.78s

After:

✓ building client + server bundles - 23.69 seconds
✓ rendering pages - 2 minutes, 49.81 seconds
✓ generating sitemap - 0.03 seconds
build complete in 3 minutes, 13.78 seconds

The latest commit implements the progress indicator - screen recording

closes #3384

@zhangyx1998 zhangyx1998 changed the title feat(build): log duration for each task, use humanized format feat(build): show progress during render, log duration for each task, use humanized format Dec 28, 2023
@zhangyx1998 zhangyx1998 mentioned this pull request Dec 30, 2023
Open
zhangyx1998 added a commit to zhangyx1998/vitepress that referenced this pull request Jan 8, 2024
@zhangyx1998
strip changes from vuejs#3385
1dd35b2
@brc-dd brc-dd self-assigned this Jan 12, 2024
@github-actions github-actions bot added the stale label Feb 15, 2024
@github-actions github-actions bot removed the stale label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brc-dd brc-dd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[build] add progress indication for task()
2 participants
@zhangyx1998 @brc-dd