Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide JS-required features if JS disabled #2912

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Hide JS-required features if JS disabled #2912

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
764f943
Hide JS-required features if JS disabled
Pandapip1 Sep 6, 2023
992a93e
Hide Search in no-JS mode
Pandapip1 Sep 6, 2023
7d98f4d
Disable light/dark mode slider when JS disabled
Pandapip1 Sep 6, 2023
fc6befb
Mark as !important, just in case
Pandapip1 Sep 6, 2023
a73bdc2
Mark hamburger menu as js-required
Pandapip1 Sep 6, 2023
a440088
minify
brc-dd Sep 10, 2023
20a11d0
add noscript on renderer not dev plugin
brc-dd Sep 10, 2023
3d57927
Remove local nav
Pandapip1 Sep 10, 2023
ffc9871
Hide copy code buttons when JS disabled
Pandapip1 Sep 10, 2023
0e89160
Make VPFlyout require JS
Pandapip1 Sep 10, 2023
4c27721
Merge branch 'main' into patch-2
Pandapip1 Mar 11, 2024
309e6a8
Merge branch 'main' into patch-2
Pandapip1 Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/client/theme-default/components/VPNavBar.vue
View file
Open in desktop
Expand Up @@ -49,14 +49,14 @@ watchPostEffect(() => {
<div class="curtain" />
<div class="content-body">
<slot name="nav-bar-content-before" />
<VPNavBarSearch class="search" />
<VPNavBarSearch class="search js-required" />
<VPNavBarMenu class="menu" />
<VPNavBarTranslations class="translations" />
<VPNavBarAppearance class="appearance" />
<VPNavBarSocialLinks class="social-links" />
<VPNavBarExtra class="extra" />
<slot name="nav-bar-content-after" />
<VPNavBarHamburger class="hamburger" :active="isScreenOpen" @click="$emit('toggle-screen')" />
<VPNavBarHamburger class="hamburger js-required" :active="isScreenOpen" @click="$emit('toggle-screen')" />
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion src/client/theme-default/components/VPNavBarExtra.vue
View file
Open in desktop
Expand Up @@ -28,7 +28,7 @@ const hasExtraContent = computed(
</template>
</div>

<div v-if="site.appearance" class="group">
<div v-if="site.appearance" class="group js-required">
<div class="item appearance">
<p class="label">
{{ theme.darkModeSwitchLabel || 'Appearance' }}
Expand Down
1 change: 1 addition & 0 deletions src/node/plugin.ts
View file
Open in desktop
Expand Up @@ -266,6 +266,7 @@ export async function createVitePressPlugin(
<meta charset="utf-8">
<meta name="viewport" content="width=device-width,initial-scale=1">
<meta name="description" content="">
<noscript><style>.js-required{display:none!important}</style></noscript>
</head>
<body>
<div id="app"></div>
Expand Down