Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): display file name when rendering fails #2373

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Pandapip1
Copy link

@Pandapip1 Pandapip1 commented May 15, 2023

This small patch will save many people a LOT of time debugging. It would have saved me at least an hour.

I can't imagine that it's intentional that there is no information regarding which file caused rendering to fail, so that's why I'm calling this a fix.

@Pandapip1 Pandapip1 changed the title Display file name when rendering fails fix: Display file name when rendering fails May 15, 2023
@brc-dd
Copy link
Member

brc-dd commented Jul 1, 2023

Can you provide me a minimal reproducible example where the error stack has no mention of corresponding file?

@Pandapip1
Copy link
Author

I made this PR a few months ago, so I can't remember the exact issue I had. I believe that I made a typo and tried to acccess a property of an undefined variable. This should repro:

{{ shsghs.hfhfh  }}

@brc-dd
Copy link
Member

brc-dd commented Jul 16, 2023

That already shows the file name:

image


I agree it shows that in a way that might not be immediately clear (replaces / with _ and the paths are relative to the temp directory).

@Pandapip1
Copy link
Author

I think you misunderstand. This shows the file name of the markdown file where the error occurred, not the file name of the script in which the error occurred.

@Pandapip1
Copy link
Author

I'm kinda stuck with using my own patch for debugging until this is merged.

@brc-dd brc-dd force-pushed the main branch 2 times, most recently from 7ad4a4e to f0d3082 Compare August 3, 2023 10:20
@brc-dd
Copy link
Member

brc-dd commented Aug 21, 2023

I think you misunderstand. This shows the file name of the markdown file where the error occurred, not the file name of the script in which the error occurred.

But the name of markdown file is easily inferable from the script name. an error in .temp/foo_bar.md.js means an error in foo/bar.md

@brc-dd brc-dd closed this Aug 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2023
@vuejs vuejs unlocked this conversation Sep 21, 2023
@brc-dd brc-dd reopened this Sep 21, 2023
@brc-dd brc-dd changed the title fix: Display file name when rendering fails fix(build): display file name when rendering fails Sep 21, 2023
@github-actions github-actions bot added the stale label Nov 6, 2023
@github-actions github-actions bot removed the stale label Nov 25, 2023
@github-actions github-actions bot added the stale label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants