Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null should be preserved in relative navigations #2083

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Commits on Dec 15, 2023

  1. fix: null should be preserved in relative navigations

    The fix is a bit more complicated that I anticipated, I will come back
    to this later on as the currently documented version works perfectly.
    
    - the nullish params are removed before being passed to the matcher
    - The encodeParam function transform null into ''
    - The applyToParams also works with arrays but it makes no sense to
      allow null in array params
    
    Ideally, I would make the matcher a bit more permissive so the encoding
    is kept at the router level. I think the matcher sholud be responsible
    for removing the nullish parameters but that also means the encode
    function should leave nullish values untouched. We might need an
    intermediate Type for this shape of Params, it gets a little bit tedious
    in terms of types, so I would like to avoid adding more types.
    
    Close #1893
    posva committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    c93e259 View commit details
    Browse the repository at this point in the history