Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add the guide for self-host translations [skip ci] #1788

Merged
merged 2 commits into from
Apr 21, 2023

Conversation

Jinjiang
Copy link
Member

@Jinjiang Jinjiang commented Apr 9, 2023

@posva for translations hosted in a different repo, I added more content in the contributing.md. Do you think that makes sense? Thanks.

@netlify
Copy link

netlify bot commented Apr 9, 2023

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit a40488d
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/6433e256de6b6a0008deab4d

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Merging #1788 (f45de45) into main (4b08a12) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main    #1788   +/-   ##
=======================================
  Coverage   90.86%   90.86%           
=======================================
  Files          24       24           
  Lines        1116     1116           
  Branches      347      347           
=======================================
  Hits         1014     1014           
  Misses         63       63           
  Partials       39       39           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tried improving the wording a bit. Let me know what you think!

.github/contributing.md Outdated Show resolved Hide resolved
.github/contributing.md Outdated Show resolved Hide resolved
.github/contributing.md Outdated Show resolved Hide resolved
Co-authored-by: Eduardo San Martin Morote <[email protected]>
@Jinjiang
Copy link
Member Author

@posva all look great. Updated as well. Thanks.

@posva posva changed the title chore: add the guide for self-host translations chore: add the guide for self-host translations [skip ci] Apr 21, 2023
@posva posva merged commit dcafc02 into main Apr 21, 2023
6 checks passed
@posva posva deleted the jinjiang/contributing/self-host-translations branch April 21, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants