bind bugs - supporting onclick attribute, retaining class attribute, walk bug - processDirective correctly removing attributes with 'modifiers', block bug - only remove template element if isConnected #186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
raw
variable was modified to remove any modifiers, then later used to attempt to remove the attribute;el.removeAttribute(raw)
. But if a modifier was present -@click.prevent
, theremoveAttribute
attempts to find@click
instead of@click.prevent
.Additionally, made bind.ts support force the
:onclick
binding as an attribute. When not an attribute and just assigned to the element property, it did not work. There were times when I couldn't use the@click
directive and was forced to use:onclick
(to support a legacy framework rendering elements by 'cloning them' and then losing the petite-vue event binding).