Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use definition from defineProps if possible #3838

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: use definition from defineProps if possible #3838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
33db74c
fix
so1ve Jan 2, 2024
3fdd529
Merge branch 'master' into pr/3838
johnsoncodehk Apr 30, 2024
f8bbcc4
Fixes
johnsoncodehk Apr 30, 2024
48addc3
Merge branch 'master' into pr/3838
johnsoncodehk Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 9 additions & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -27,5 +27,14 @@
"typescript": "latest",
"vite": "latest",
"vitest": "latest"
},
"pnpm": {
"overrides": {
"@vue/runtime-dom": "alpha",
"@vue/shared": "alpha",
"@vue/compiler-dom": "alpha",
"@vue/compiler-sfc": "alpha",
"vue": "alpha"
}
Comment on lines +31 to +38
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't doing overrides at this level also affect/break vue 2 tests?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not affect Vue 2 tests. Since this PR will only be merged when Vue 3.5 is released, this json section will be removed before merging.

}
}
162 changes: 75 additions & 87 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions test-workspace/tsc/vue3/#3779/main.vue
View file
Open in desktop
@@ -0,0 +1,10 @@
<script setup lang="ts">
import { exactType } from '../../shared';
defineProps<{
optionalBoolean?: boolean;
}>();
</script>

<template>
<h1>{{ exactType(optionalBoolean, {} as boolean | undefined) }}</h1>
</template>
10 changes: 10 additions & 0 deletions test-workspace/tsc/vue3/#3779/named.vue
View file
Open in desktop
@@ -0,0 +1,10 @@
<script setup lang="ts">
import { exactType } from '../../shared';
const props = defineProps<{
optionalBoolean?: boolean;
}>();
</script>

<template>
<h1>{{ exactType(optionalBoolean, true as boolean) }}</h1>
</template>
19 changes: 19 additions & 0 deletions test-workspace/tsc/vue3/#3820/main.vue
View file
Open in desktop
@@ -0,0 +1,19 @@
<script setup lang="ts" generic="T extends { name: string }">
const props = defineProps<{
one: T;
all: Array<T>;
}>();
</script>

<template>
<div>
<!-- incorrect inference -->
<div>{{ one.name }}</div>
<!-- correct inference -->
<div>{{ props.one.name }}</div>
<ul>
<!-- correct inference -->
<li v-for="el in all">{{ el.name }}</li>
</ul>
</div>
</template>