Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add warning to custom-directives #2850

Merged

Conversation

xiaodong2008
Copy link
Contributor

Please refer to #2849

Copy link

netlify bot commented May 2, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit fa6b5e7
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/663493137a6bcb000820d6bf
😎 Deploy Preview https://deploy-preview-2850--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, @xiaodong2008! I've made a small change for the same of efficiency but rest of the PR looks great to me, approved 👍🏻

@NataliaTepluhina NataliaTepluhina linked an issue May 3, 2024 that may be closed by this pull request
@NataliaTepluhina NataliaTepluhina merged commit 3044a81 into vuejs:main May 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: unobvious warning in custom-directives
3 participants