Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: uwu logo style & alt text from Home.vue #2846

Merged
merged 1 commit into from May 1, 2024

Conversation

yamanoku
Copy link
Contributor

@yamanoku yamanoku commented May 1, 2024

Description of Problem

  • Insert alternative text for the logo itself (because this is a meaningful logo image, not a background image)
  • To prevent layout shift for the image, specify the width and height
  • The :global specification is meaningless since CSS Modules are not being used

Copy link

netlify bot commented May 1, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit ed72958
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/66320fcbc9a3a60008950b4b
😎 Deploy Preview https://deploy-preview-2846--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NataliaTepluhina NataliaTepluhina merged commit 12a2591 into vuejs:main May 1, 2024
5 checks passed
@yamanoku yamanoku deleted the fix-uwu-logo branch May 1, 2024 10:47
@yyx990803
Copy link
Member

FYI the original implementation was intentional because we don't want to load the image when the users didn't explicitly have ?uwu in the URL...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants