Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs #2821: fix writing mistakes in letter case #2828

Merged
merged 3 commits into from Apr 30, 2024

Conversation

xiaodong2008
Copy link
Contributor

@xiaodong2008 xiaodong2008 commented Apr 26, 2024

Description of Problem

Some letters should be capitalised, check below:

+ <button>Click Me</button>
+ <h1>Title</h1>
+ <p>This is a paragraph or sentence</p>
+ <p>Count: 0</p>
- <p>short text/word</p> // no need to capitalised

Refers to #2821

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit dae7ff9
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6630b4cdb4120500084d6415
😎 Deploy Preview https://deploy-preview-2828--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @xiaodong2008! I agree with most of the casing changes, but removing the is in the examples isn't related to letter casing and arguably is better as is since it is more explicit as a statement.

Once you remove those changes, I'm happy to approve and merge these changes!

@bencodezen bencodezen added the state: needs-changes PR requires changes to proceed label Apr 29, 2024
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @xiaodong2008!

@bencodezen bencodezen merged commit 7ae6897 into vuejs:main Apr 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: needs-changes PR requires changes to proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants