Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "update: add "Kevin Deng" to core member" #2790

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/about/team/Member.ts
Expand Up @@ -5,7 +5,7 @@ export interface Member {
company?: string
companyLink?: string
projects: Link[]
location: string | string[]
location: string
languages: string[]
website?: Link
socials: Socials
Expand Down
16 changes: 3 additions & 13 deletions src/about/team/TeamMember.vue
Expand Up @@ -24,10 +24,6 @@ const avatarUrl = computed(() => {
`https://www.github.com/${props.member.socials.github}.png`
)
})

function arrayify(value: string | string[]): string[] {
return Array.isArray(value) ? value : [value]
}
</script>

<template>
Expand Down Expand Up @@ -97,15 +93,9 @@ function arrayify(value: string | string[]): string[] {
<h2 class="sr-only">Location</h2>
<VTIconMapPin class="desc-icon" />
</div>
<ul class="desc-list">
<li
v-for="location in arrayify(member.location)"
:key="location"
class="desc-item"
>
{{ location }}
</li>
</ul>
<p class="desc-text">
{{ member.location }}
</p>
</section>

<section class="desc">
Expand Down
63 changes: 31 additions & 32 deletions src/about/team/TeamPage.vue
@@ -1,17 +1,17 @@
<script lang="ts">
const shuffleMembers = (
members: Member[],
pinTheFirstMember = false
): void => {
const shuffleMembers = (members: Member[], pinTheFirstMember = false): void => {
let offset = pinTheFirstMember ? 1 : 0
// `i` is between `1` and `length - offset`
// `j` is between `0` and `length - offset - 1`
// `offset + i - 1` is between `offset` and `length - 1`
// `offset + j` is between `offset` and `length - 1`
let i = members.length - offset
while (i > 0) {
const j = Math.floor(Math.random() * i)
;[members[offset + i - 1], members[offset + j]] = [
const j = Math.floor(Math.random() * i);
[
members[offset + i - 1],
members[offset + j]
] = [
members[offset + j],
members[offset + i - 1]
]
Expand All @@ -37,47 +37,46 @@ shuffleMembers(membersPartnerData as Member[])
<div class="TeamPage">
<TeamHero>
<template #title>Meet the Team</template>
<template #lead>
The development of Vue and its ecosystem is guided by an
international team, some of whom have chosen to be
<span class="nowrap">featured below.</span>
</template>
<template #lead
>The development of Vue and its ecosystem is guided by an international
team, some of whom have chosen to be
<span class="nowrap">featured below.</span></template
>

<template #action>
<VTLink
href="https://github.com/vuejs/governance/blob/master/Team-Charter.md"
>Learn more about teams</VTLink
>
Learn more about teams
</VTLink>
</template>
</TeamHero>

<TeamList :members="(membersCoreData as Member[])">
<TeamList :members="membersCoreData as Member[]">
<template #title>Core Team Members</template>
<template #lead>
Core team members are those who are actively involved in the
maintenance of one or more core projects. They have made
significant contributions to the Vue ecosystem, with a long term
commitment to the success of the project and its users.
</template>
<template #lead
>Core team members are those who are actively involved in the
maintenance of one or more core projects. They have made significant
contributions to the Vue ecosystem, with a long term commitment to the
success of the project and its users.</template
>
</TeamList>

<TeamList :members="(membersEmeritiData as Member[])">
<TeamList :members="membersEmeritiData as Member[]">
<template #title>Core Team Emeriti</template>
<template #lead>
Here we honor some no-longer-active core team members who have made
valuable contributions in the past.
</template>
<template #lead
>Here we honor some no-longer-active core team members who have made
valuable contributions in the past.</template
>
</TeamList>

<TeamList :members="(membersPartnerData as Member[])">
<TeamList :members="membersPartnerData as Member[]">
<template #title>Community Partners</template>
<template #lead>
Some members of the Vue community have so enriched it, that they
deserve special mention. We've developed a more intimate
relationship with these key partners, often coordinating with them
on upcoming features and news.
</template>
<template #lead
>Some members of the Vue community have so enriched it, that they
deserve special mention. We've developed a more intimate relationship
with these key partners, often coordinating with them on upcoming
features and news.</template
>
</TeamList>
</div>
</template>
Expand Down
29 changes: 0 additions & 29 deletions src/about/team/members-core.json
Expand Up @@ -507,34 +507,5 @@
"twitter": "_brc_dd"
},
"sponsor": true
},
{
"name": "Kevin Deng 三咲智子",
"title": "Open Sourceror",
"projects": [
{
"label": "vuejs/core",
"url": "https://github.com/vuejs/core"
},
{
"label": "vuejs/core-vapor",
"url": "https://github.com/vuejs/core-vapor"
},
{
"label": "Vue Macros",
"url": "https://github.com/vue-macros/vue-macros"
},
{
"label": "VueUse",
"url": "https://github.com/vueuse/vueuse"
}
],
"location": ["Hangzhou", "Singapore"],
"languages": ["English", "Chinese"],
"socials": {
"github": "sxzz",
"twitter": "sanxiaozhizi"
},
"sponsor": true
}
]