Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #2769

Merged
merged 1 commit into from Mar 27, 2024
Merged

fix typo #2769

merged 1 commit into from Mar 27, 2024

Conversation

chengr4
Copy link
Contributor

@chengr4 chengr4 commented Mar 27, 2024

Description of Problem

I wonder if this is a typo.

Additional Information

It may affect other translation.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 1d0d423
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6603d68f9883030007f6759a
😎 Deploy Preview https://deploy-preview-2769--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brc-dd brc-dd merged commit ccf052d into vuejs:main Mar 27, 2024
5 checks passed
@AloisSeckar
Copy link
Contributor

@brc-dd I am pretty sure this wasn't a typo as the sentence is referencing to ":title="post.title" component prop, not to the v-for cycle itself. This PR should either be reverted, or wording should be changed. Because NOW it became confusing...

@brc-dd
Copy link
Member

brc-dd commented Mar 27, 2024

Ah right. This was the original code:

```html
<div id="blog-posts-demo">
<blog-post
v-for="post in posts"
v-bind:key="post.id"
v-bind:title="post.title"
></blog-post>
</div>
```
Above, you'll see that we can use `v-bind` to dynamically pass props. This is especially useful when you don't know the exact content you're going to render ahead of time.

Maybe we should reword it to something like - Notice how [`v-bind` syntax](/api/built-in-directives#v-bind) (`:title="post.title"`) is used is used to pass ...

brc-dd added a commit that referenced this pull request Mar 27, 2024
This reverts commit ccf052d.
@AloisSeckar
Copy link
Contributor

Good improvement, thank you ^_^

@chengr4
Copy link
Contributor Author

chengr4 commented Mar 28, 2024

Thank you all.
I apologize for my misunderstanding, and thank you for teaching me something

@AloisSeckar
Copy link
Contributor

No need to appologize. You helped to make it clearer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants