Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation link to ru.vuejs.org #2757

Merged
merged 5 commits into from Mar 30, 2024
Merged

Conversation

Ibochkarev
Copy link
Contributor

@Ibochkarev Ibochkarev commented Mar 18, 2024

Description of Problem

Hello @yyx990803 and @bencodezen, i am a member of the organization translation-gang.

We have finished translating the documentation into Russian and would like to place a link to the official website of the documentation with the translation, as well as link the domain https://ru.vuejs.org/ for https://vuejs-doc-ru.vercel.app/.

You can help with the domain and consider this PR?

PS: Added additional information here #478 (comment)

Repository: https://github.com/vuejs-translations/docs-ru

Discussion: https://github.com/orgs/vuejs-translations/discussions/12#discussioncomment-8756236

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit ba563a2
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/6607feacd08a65000896a18e
😎 Deploy Preview https://deploy-preview-2757--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vladdof
Copy link

vladdof commented Mar 18, 2024

Super) faster in production

@NataliaTepluhina
Copy link
Member

NataliaTepluhina commented Mar 19, 2024

@Ibochkarev would it be fine to transfer the translation to vuejs-translations organisation (please see step 4 here: https://github.com/vuejs-translations/guidelines?tab=readme-ov-file#high-level-steps-of-working-on-a-new-translation). This way we could handle the deployments from our end.

@Ibochkarev
Copy link
Contributor Author

@Jinjiang The repository has been moved https://github.com/vuejs-translations/docs-ru

Discussion https://github.com/orgs/vuejs-translations/discussions/12#discussioncomment-8756236

@Ibochkarev Ibochkarev changed the title Feat: Add russian translation site link Add translation link to ru.vuejs.org Mar 20, 2024
@Ibochkarev
Copy link
Contributor Author

@Ibochkarev would it be fine to transfer the translation to vuejs-translations organisation (please see step 4 here: https://github.com/vuejs-translations/guidelines?tab=readme-ov-file#high-level-steps-of-working-on-a-new-translation). This way we could handle the deployments from our end.

Done

@Jinjiang
Copy link
Member

Please also update this page https://github.com/vuejs/docs/blob/main/src/translations/index.md
The domain is under deploying. Then after all this PR is able to be merged. Thanks.

@Ibochkarev
Copy link
Contributor Author

@Jinjiang done

@Ibochkarev
Copy link
Contributor Author

@Jinjiang Good afternoon.

Are there any difficulties with deploying the domain and do we need something from our side?

@Jinjiang
Copy link
Member

Sorry for waiting. It still takes some time. Will keep you posted here. 🙏

@yyx990803 yyx990803 merged commit d77e5a1 into vuejs:main Mar 30, 2024
5 checks passed
@yyx990803
Copy link
Member

DNS updated - may require some time for SSL certs to be generated. Congrats and thanks to everyone who contributed!

@Ibochkarev Ibochkarev deleted the patch-1 branch March 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants