Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: recommend petite-vue for no build approaches #2558

Conversation

nazarepiedady
Copy link
Contributor

@nazarepiedady nazarepiedady commented Nov 2, 2023

Description of Problem

The mainstream bundle of Vue.js is too big or not the best for setups that do not have a build system or are too minimalist, so while I was reviewing the documentation, I found one possible enhancement for the documentation.

Proposed Solution

So, I added a note recommending users give a chance to the petite-vue for no-build setups and minimalist approaches.

How This Look Like?

petite-vue-recommendation

Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 58e17db
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/65d786049a51c0000782499a
😎 Deploy Preview https://deploy-preview-2558--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nazarepiedady
Copy link
Contributor Author

@Jinjiang and @patak-dev could you review it to see if it is a good idea?

@bencodezen
Copy link
Member

@nazarepiedady Thanks for the PR! I like the idea of suggesting petite-vue to the community, but we probably don't want to overload the page with more notification blocks. Would you consider revising the PR as an addendum to the existing block regarding using Vue with a CDN?

Let me know if you need additional guidance!

@bencodezen bencodezen self-requested a review November 29, 2023 17:27
@bencodezen bencodezen added the state: awaiting-feedback Needs more input before further actions can be taken label Nov 29, 2023
@nazarepiedady
Copy link
Contributor Author

@bencodezen I had an idea about your suggestion so I did an update, what do you think about it?

Could it be better? I am willing to make the updates that are needed.

@bencodezen
Copy link
Member

@nazarepiedady My apologies for falling off on getting you feedback on this.

It looks like the PR is overloaded with files not related to the petite-vue solution.

Could you please update the branch so that the only changes are the doc changes related to the original problem?

@nazarepiedady nazarepiedady force-pushed the recommend-using-petite-vue-for-no-build-setup branch from f784286 to aa999b9 Compare February 2, 2024 20:20
@nazarepiedady
Copy link
Contributor Author

@bencodezen, sorry for the delay, but I already fixed the pull request, I think it is ready for the merge.

Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @nazarepiedady!

@bencodezen bencodezen merged commit b48716c into vuejs:main Feb 22, 2024
4 of 5 checks passed
@nazarepiedady nazarepiedady deleted the recommend-using-petite-vue-for-no-build-setup branch February 23, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: awaiting-feedback Needs more input before further actions can be taken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants