Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript With Slots section #2431

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add TypeScript With Slots section #2431

wants to merge 2 commits into from

Conversation

tdgao
Copy link

@tdgao tdgao commented Jul 6, 2023

Description of Problem

Missing a typing slots section in Vue slots doc. This section is relevant to Typescript users who are looking to type their slots.

Proposed Solution

Add the missing section with a link to the defineSlots() docs

@netlify
Copy link

netlify bot commented Jul 6, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 37e6c4b
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/64a70be0a872fe0008bb510c
😎 Deploy Preview https://deploy-preview-2431--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tdgao tdgao changed the title Add typing slots section Add TypeScript With Slots section Jul 6, 2023
Copy link
Member

@NataliaTepluhina NataliaTepluhina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tdgao thank you for your contribution! However, we don't usually provide TS options in the guide/components section. Maybe guide/typescript would be a better option?

@NataliaTepluhina NataliaTepluhina added state: stale This PR wasn't updated for a long time and removed state: stale This PR wasn't updated for a long time labels Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: stale This PR wasn't updated for a long time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants