use onBeforeUnmount in useEventListener #2356
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
onBeforeUnmount
inuseEventListener
instead ofonUnmounted
sinceonUnmounted
will not work if you trying to pass some element ref from the consumer component. Using theonUnmounted
the ref will be null since the component is unmounted, so we should useonBeforeUnmount
Description of Problem
using will throw an error:
if you use Element ref
Proposed Solution
Use
onBeforeUnmount
, no remove the listener just before destroying the component