Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword the section on in-DOM root templates #2332

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

skirtles-code
Copy link
Contributor

This change was motivated by #1864.

The section on using an in-DOM template begins by introducing it as a feature used without a build step. That is one use case, but it is also commonly used with server-side frameworks that generate the template HTML dynamically.

While import { createApp } from 'vue' can be used 'without a build step', it does seem less natural in that context. This was the problem originally raised in #1864. The idea of using import maps is discussed earlier in the docs, but this specific example leans on that knowledge more heavily than the rest of the docs.

Instead, I've started by introducing the feature without explicit motivation, contrasting it with the more common approach. I've then mentioned the use cases at the end, including a link back to the section about using Vue without build tools.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit d45f4a2
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/644367507515be0008382f45
😎 Deploy Preview https://deploy-preview-2332--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NataliaTepluhina NataliaTepluhina merged commit 378a4e6 into vuejs:main Apr 24, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants