Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reword type assertions with events #2330

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

skirtles-code
Copy link
Contributor

This change is inspired by the suggestion in #2174.

The use of the word 'cast' does seem to match how it is commonly used in a TypeScript context. However, it does have a slightly different meaning in other languages, and the TS docs seem to stay clear of using that word.

However, the proposal in #2174 to change it to the word 'assert' seemed less natural to me, even if it could be seen as more technically correct.

Instead, I've tried rewording the whole sentence, aiming to make it sound more like something from the TS docs.

The same sentence appears in both pages about TS usage, so I've applied the same change to both.

@netlify
Copy link

netlify bot commented Apr 22, 2023

Deploy Preview for vuejs ready!

Name Link
🔨 Latest commit 2d75a9d
🔍 Latest deploy log https://app.netlify.com/sites/vuejs/deploys/644332799d91920007a30cb3
😎 Deploy Preview https://deploy-preview-2330--vuejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NataliaTepluhina NataliaTepluhina merged commit ac42b95 into vuejs:main Apr 24, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants