Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter tree/states for custom inspectors #664

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

alexzhang1030
Copy link
Member

closes #657

Leave a Todo here, The pinia applet is very similar to the custom inspector applet, we should extract the common logic into a composable.

Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 4a08343
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/6723a73c5da65700087e799e

Copy link

pkg-pr-new bot commented Oct 31, 2024

Open in Stackblitz

@vue/devtools-applet

pnpm add https://pkg.pr.new/@vue/devtools-applet@664

@vue/devtools-core

pnpm add https://pkg.pr.new/@vue/devtools-core@664

@vue/devtools

pnpm add https://pkg.pr.new/@vue/devtools@664

@vue/devtools-api

pnpm add https://pkg.pr.new/@vue/devtools-api@664

@vue/devtools-kit

pnpm add https://pkg.pr.new/@vue/devtools-kit@664

vite-plugin-vue-devtools

pnpm add https://pkg.pr.new/vite-plugin-vue-devtools@664

commit: 4a08343

@webfansplz
Copy link
Member

Great work. But when I tested it, I found that it caused the custom inspector state don't display as expected.

@alexzhang1030
Copy link
Member Author

curious about that, I did not update any core logic

@webfansplz
Copy link
Member

curious about that, I did not update any core logic

You can reproduce it in the basic playground's Vuex and Vue Query panel

@alexzhang1030
Copy link
Member Author

curious about that, I did not update any core logic

You can reproduce it in the basic playground's Vuex and Vue Query panel

@webfansplz fixed, missed something... bad js 😅

@webfansplz webfansplz changed the title feat: support search tree and states on custom inspectors feat: filter tree/states for custom inspectors Oct 31, 2024
@webfansplz
Copy link
Member

LGTM 🔥. Great work, bro.

@webfansplz webfansplz merged commit dce7c1e into vuejs:main Oct 31, 2024
7 checks passed
webfansplz added a commit that referenced this pull request Oct 31, 2024
alexzhang1030 added a commit to alexzhang1030/vue-devtools-next that referenced this pull request Oct 31, 2024
webfansplz pushed a commit that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to search through state? v3.5.12
2 participants