Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): change inspect-component icon #372

Merged
merged 5 commits into from
Jun 15, 2024

Conversation

maxirozay
Copy link
Contributor

fix issue #294
Change overlay inspector icon to avoid having the same icon than the component inspector which has a different behavior.

Copy link

netlify bot commented May 8, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit b28c6d6
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/666ab65355bcb60008dd7f9c

@alexzhang1030
Copy link
Member

This one looks nice.
image

@webfansplz
Copy link
Member

Thanks for the PR, I prefer to swap the icon of 1 and 2.

image

@maxirozay
Copy link
Contributor Author

I can do that in June unless someone wants to do it before.

@alexzhang1030
Copy link
Member

alexzhang1030 commented May 20, 2024

Never mind, do it when you have time.

@alexzhang1030
Copy link
Member

LGTM

@webfansplz webfansplz changed the title fix(overlay): Change overlay inspector icon feat(client): change inspect-component icon Jun 15, 2024
@webfansplz webfansplz merged commit f118549 into vuejs:main Jun 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants