Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Safari Web Extension #1906

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Safari Web Extension #1906

wants to merge 6 commits into from

Conversation

vad1ym
Copy link

@vad1ym vad1ym commented Jul 7, 2022

Description

I don't have enough experience in contributing and pull-requests, so I would be thankful for help.

It adds possibility to build Safari Web Extension that works similar to Chrome extension #1139
Tested with Safari Technology Preview (Safari 16.0) on Mac OS 12.4.
Builded with Xcode 14 beta 3

Safari 16 and Xcode 14 allow us to write extension with a Web Inspector tab feature.
Added shell-safari folder based on shell-chrome folder, just replaced chrome.* with browser.* in some code lines.
Added shell-safari/app folder with Xcode Safari Web Extension Folder.
Added some scripts to package.json for building the extension app

How to build extension

  1. yarn build
  2. cd packages/shell-safari
  3. yarn safari
    Builded extension app: packages/shell-safari/app/extension/VueDevTools.app

P.S. To see extension from Safari preferences you should activate Develop/Allow Unsigned Extensions. To avoid this, the extension must be signed with Apple Developer Account.

Additional context

I guess, it should use same code base for Chrome and Safari (with chrome.* and browser.* difference), but I think it should be done by main developers of this repository.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).

@Akryum
Copy link
Member

Akryum commented Jul 26, 2022

We should try to reuse the chrome folder instead of duplicating code I guess

@50rayn
Copy link

50rayn commented Dec 28, 2022

Are there any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants