Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client/bridge): enable deletion of property on Map/Set #163

Conversation

Azurewarth0920
Copy link
Collaborator

@Azurewarth0920 Azurewarth0920 commented Jan 8, 2024

Fix: #161

  • Fix the issue that the reactive object cannot be passed to window.postMessage
  • Enable deletion of property on Map/Set
  • Fix clicking on the deletion button will accidentally toggle the property.

FYI: There are still some problems with deserializing/serializing on custom objects.
We can fix it on another PR.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for vue-devtools-docs ready!

Name Link
🔨 Latest commit 9a52898
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/659c155d934d8e0007095113
😎 Deploy Preview https://deploy-preview-163--vue-devtools-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alexzhang1030 alexzhang1030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@webfansplz webfansplz changed the title fix(client/bridge): Fix unable to delete Pinia's array member fix(client/bridge): enable deletion of property on Map/Set Jan 9, 2024
@webfansplz webfansplz merged commit 80ae1dc into vuejs:main Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete button does not delete pinia item in the array
3 participants