Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(electron): compatible with windows #153

Merged
merged 4 commits into from
Jan 5, 2024
Merged

fix(electron): compatible with windows #153

merged 4 commits into from
Jan 5, 2024

Conversation

alexzhang1030
Copy link
Member

fixes #146

@netlify Netlify
Copy link

netlify bot commented Jan 5, 2024 •
edited
Loading

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 78e11ef
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/6597bc7dbe93910008bd715e

@alexzhang1030 alexzhang1030 mentioned this pull request Jan 5, 2024
Closed
webfansplz
webfansplz reviewed Jan 5, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@alexzhang1030
Copy link
Member Author

alexzhang1030 commented Jan 5, 2024 •
edited
Loading

I think we can merge now since someone has tested it

@webfansplz webfansplz changed the title fix(electron): windows compatiable fix(electron): compatible with windows Jan 5, 2024
@webfansplz
Copy link
Member

Great work!

@webfansplz webfansplz merged commit 54de0e5 into vuejs:main Jan 5, 2024
6 checks passed
@alexzhang1030 alexzhang1030 deleted the fi/electron branch January 5, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfansplz webfansplz webfansplz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot open standalone app
2 participants
@alexzhang1030 @webfansplz