Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: use Set.has instead of Array.includes #140

Merged
merged 1 commit into from
Jan 4, 2024
Merged

perf: use Set.has instead of Array.includes #140

merged 1 commit into from
Jan 4, 2024

Conversation

Azurewarth0920
Copy link
Collaborator

@Azurewarth0920 Azurewarth0920 commented Jan 3, 2024 •
edited
Loading

Set.has has O(1) performance, which is faster than Array.includes's O(n).

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2024 •
edited
Loading

✅ Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 4061396
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/65956f5ec4295c00084adebc

@webfansplz webfansplz changed the title feat(pref): Use faster Set.has instead of Array.includes in searching VueBuiltins perf: use Set.has instead of Array.includes Jan 4, 2024
@webfansplz webfansplz merged commit c8eba5a into vuejs:main Jan 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexzhang1030 alexzhang1030 alexzhang1030 approved these changes

@webfansplz webfansplz webfansplz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Azurewarth0920 @webfansplz @alexzhang1030