Revert "fix: disconnect when all apps are unmount (#357)"

This reverts commit a12c816.
vuejs · May 19, 2024 · 06854c7 · 06854c7
1 parent fdac6eb
commit 06854c7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/packages/devtools-kit/src/core/index.ts b/packages/devtools-kit/src/core/index.ts
@@ -56,7 +56,7 @@ export function initDevTools() {
       },
     ]
 
-    if (devtoolsAppRecords.value.length >= 1) {
+    if (devtoolsAppRecords.value.length === 1) {
       await setActiveAppRecord(devtoolsAppRecords.value[0])
       devtoolsState.connected = true
       devtoolsHooks.callHook(DevToolsHooks.APP_CONNECTED)
@@ -65,11 +65,6 @@ export function initDevTools() {
 
   hook.on.vueAppUnmount(async (app) => {
     const activeRecords = devtoolsAppRecords.value.filter(appRecord => appRecord.app !== app)
-    // #356 should disconnect when all apps are unmounted
-    if (activeRecords.length === 0) {
-      devtoolsState.connected = false
-      return
-    }
     devtoolsAppRecords.value = activeRecords
     if (devtoolsAppRecords.active.app === app)
       await setActiveAppRecord(activeRecords[0])

diff --git a/packages/playground/multi-app/src/main.ts b/packages/playground/multi-app/src/main.ts
@@ -8,10 +8,8 @@ import 'uno.css'
 
 const app = createApp(App)
 
+const app2 = createApp(App2)
+
 app.mount('#app')
 
-setTimeout(() => {
-  app.unmount()
-  app.mount('#app')
-  createApp(App2).mount('#app2')
-}, 500)
+app2.mount('#app2')