Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tailwind support #416

Closed
wants to merge 3 commits into from

Conversation

Yordan-Ramchev
Copy link
Contributor

@Yordan-Ramchev Yordan-Ramchev commented Dec 30, 2023

Hi @sodatea @cexbrayat,

I've opened a pull request(re #246) that introduces:

  1. Introduced Tailwind prompt functionality with an untranslated prompt message.
  2. Ensured compatibility for both JavaScript (js) and TypeScript (ts) scenarios.
  3. Modified generateReadme.ts for necessary updates.
  4. Incorporated the Tailwind feature flag into snapshot.mjs.

I would appreciate your time and expertise in reviewing these changes.

Thank you!

@bmulholland
Copy link

One concern is that the approach at https://github.com/vuejs/create-vue-templates is n! on the number of options. Probably also the CI matrices? There's already a lot of directories in that repo, and over 100 CI checks... at what point will that approach break down?

I recognize that this is not about your code itself, but about the practicalities of maintaining all combinations of options.

At a minimum, you probably need to add the tailwind option to https://github.com/vuejs/create-vue/blob/main/.github/workflows/ci.yml

@Yordan-Ramchev
Copy link
Contributor Author

Yordan-Ramchev commented Jan 2, 2024

@bmulholland thank you for the feedback. I have added tailwind flag in CI and that's (n! on the number of options) a reasonable concern

@cexbrayat
Copy link
Member

cexbrayat commented Jan 25, 2024

Note: this PR is a duplicate of an older PR #245 If one of the two is merged, the other can be closed.

I personally don't think it's worth the added complexity to add tailwind support, but I'll let @sodatea decide.

@Yordan-Ramchev Yordan-Ramchev deleted the add-tailwind-option branch February 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants