Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler): compiler supports search tag #9249

Open
wants to merge 82 commits into
base: minor
Choose a base branch
from
Open

feat(compiler): compiler supports search tag #9249

wants to merge 82 commits into from

Conversation

baiwusanyu-c
Copy link
Member

close: #9247

@github-actions
Copy link

github-actions bot commented Sep 19, 2023 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 102 kB (+3.24 kB) 38.6 kB (+1.15 kB) 34.7 kB (+956 B)
vue.global.prod.js 161 kB (+4.22 kB) 58.5 kB (+1.21 kB) 52 kB (+1.04 kB)

Usages

Name Size Gzip Brotli
createApp 55.2 kB (+1.02 kB) 21.2 kB (+235 B) 19.4 kB (+240 B)
createSSRApp 59.1 kB (+1 kB) 22.9 kB (+282 B) 20.9 kB (+248 B)
defineCustomElement 59.9 kB (+1.1 kB) 22.8 kB (+302 B) 20.7 kB (+238 B)
overall 68.9 kB (+1.16 kB) 26.3 kB (+304 B) 23.9 kB (+211 B)

sxzz
sxzz previously approved these changes Sep 19, 2023
View reviewed changes
@sxzz sxzz added ready to merge The PR is ready to be merged. 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Sep 19, 2023
@baiwusanyu-c baiwusanyu-c mentioned this pull request Sep 22, 2023
Closed
@haoqunjiang haoqunjiang changed the base branch from main to minor October 19, 2023 11:05
@yyx990803
Copy link
Member

The way we handle built-in HTML tags makes this technically a breaking change if someone was previously having a component named search.

Right now:

  • If a tag is listed as built-in, it can't be registered as a component because the parser directly parses the tag as native.
  • If a tag is not listed as built-in but used in template, there will be a "failed to resolve component" warning.

Considering there might be more tags being added in the future, we might need to have a separate list of "late added tags". For these tags:

  • The parser will still parse them as potential components
  • At runtime, it will use a component with matching name if it is registered (but a "Do not use built-in tag..." warning is still thrown)
  • If no matching component is found, it falls back to render as native element, without the "failed to resolve component" warning.

@lukewarlow
Copy link

To provide a concrete example of more new tag names that might get added. https://open-ui.org/components/selectlist/ OpenUI is currently working on a new stylable select element, as part of that proposal at least 3 new Html elements are currently proposed to be added. And it's likely that more such elements will be added as time goes on. So search is definitely not going to be a one of or even necessarily a rarity.

@edison1105 edison1105 mentioned this pull request Oct 23, 2023
Closed
@sxzz sxzz force-pushed the bwsy/feat/compilerSearchElm branch from 3cfaeb0 to 13329f8 Compare October 28, 2023 07:01
@sxzz sxzz force-pushed the bwsy/feat/compilerSearchElm branch from 13329f8 to 3b41769 Compare October 28, 2023 07:02
@sxzz sxzz added need discussion and removed ready to merge The PR is ready to be merged. labels Oct 28, 2023
@sxzz sxzz dismissed their stale review October 28, 2023 07:08

Needs to discuss

@sxzz sxzz mentioned this pull request Oct 29, 2023
Merged
yyx990803 and others added 24 commits September 2, 2024 17:29
@yyx990803
fix(compiler-sfc): fix import usage check for kebab-case same name sh…
0f7c0e5 
…orthand binding

fix vuejs#11745
close vuejs#11754
@renovate
chore(deps): update build (vuejs#11769)
ab65185 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update all non-major dependencies (vuejs#11770)
1fa3290 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
chore(deps): update lint (vuejs#11773)
ec5afac 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
fix(deps): update dependency postcss to ^8.4.44 (vuejs#11774)
cb843e0 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@edison1105
fix(hydration): escape css var name to avoid mismatch (vuejs#11739)
ca12e77 
close vuejs#11735
@KazariEX
fix(server-renderer): render className during SSR (vuejs#11722)
52cdb0f
@jh-leong
fix(reactivity): correctly handle method calls on user-extended arrays (
9817c80 
vuejs#11760)

close vuejs#11759
@edison1105
fix(cssVars): correctly escape double quotes in SSR (vuejs#11784)
7b5b6e0 
close vuejs#11779
@deleteme
fix(server-renderer): Fix call to serverPrefetch in server renderer w…
6039e25 
…ith an async setup (vuejs#10893)
@Procrustes5
fix(runtime-dom): prevent unnecessary DOM update from v-model (vuejs#…
b1be9bd 
…11656)

close vuejs#11647
@jh-leong
fix(types/defineModel): allow getter and setter types to be unrelated (…
fe07f70 
…vuejs#11699)

close vuejs#11697
@Mini-ghost
fix(runtime-dom): avoid unnecessary prop patch for checkbox (vuejs#11657
c3ce9fe 
)

close vuejs#11647
@yyx990803
release: v3.5.0
6402b98
@jh-leong
fix(reactivity): handle non-array arguments in reactive concat meth…
475977a 
…od (vuejs#11794)

close vuejs#11792
@yyx990803
fix(build): improve built-in components treeshakability
4eee630
@yyx990803
chore(build): use /*@__PURE__*/ annotation consistently
4019369
@johnsoncodehk
fix(types): avoid using intersection type in Readonly<...> to fix J…
7518bc1 
…SDoc emit (vuejs#11799)
@yyx990803
fix(useTemplateRef): fix readonly warning when useTemplateRef has sam…
bc63df0 
…e variable name as template ref

close vuejs#11795
close vuejs#11802
close vuejs#11804
@edison1105
fix(Transition): avoid applying transition hooks on comment vnode (vu…
51912f8 
…ejs#11788)

close vuejs#11782
@renovate
chore(deps): update dependency puppeteer to ~23.3.0 (vuejs#11711)
540198e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@yyx990803
release: v3.5.1
1b6bc23
Merge remote-tracking branch 'upstream/main' into bwsy/fix/teleportEm…
01880aa 
…ptyTarget

# Conflicts:
#	packages/runtime-core/__tests__/components/Teleport.spec.ts
#	packages/runtime-core/src/components/Teleport.ts
@edison1105
Merge branch 'minor' into bwsy/feat/compilerSearchElm
4ab9ef2
@edison1105
Copy link
Member

The commit history in this pull request is quite extensive. Could you please squash the commits to make it more concise?

@sxzz
Copy link
Member

sxzz commented Oct 10, 2024

Because the minor branch is 2 commits ahead of main. We should update the minor branch first.

@edison1105 edison1105 deleted the branch vuejs:minor October 21, 2024 07:37
@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz left review comments

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. version: minor wait changes
Projects
Issue / PR Management
Status: Needs Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for <search> element