Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime-core): prevent users from manually calling lifecycle hook function #8731

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

refactor(runtime-core): prevent users from manually calling lifecycle hook function #8731

wants to merge 8 commits into from
+8 −3

Conversation

Alfred-Skyblue
Copy link
Member

@Alfred-Skyblue Alfred-Skyblue commented Jul 6, 2023 •
edited

We should make the lifecycle function return void to prevent users from manually calling the lifecycle function.

demo

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Aug 15, 2023
@github-actions
Copy link

github-actions bot commented Oct 19, 2023 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 86.4 kB (-1 B) 32.9 kB (-3 B) 29.7 kB (-11 B)
vue.global.prod.js 132 kB (-1 B) 49.6 kB 44.5 kB (-68 B)

Usages

Name Size Gzip Brotli
createApp 48 kB (-1 B) 18.9 kB (-1 B) 17.2 kB (+1 B)
createSSRApp 51.2 kB (-1 B) 20.2 kB (-2 B) 18.4 kB (-6 B)
defineCustomElement 50.4 kB (-1 B) 19.7 kB (-1 B) 17.9 kB (-1 B)
overall 61.3 kB (-1 B) 23.7 kB (-1 B) 21.6 kB (+1 B)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skirtles-code skirtles-code skirtles-code left review comments

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Alfred-Skyblue @sxzz @skirtles-code