Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace typeof with type guard #8505

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor: replace typeof with type guard #8505

wants to merge 2 commits into from

Conversation

Alfred-Skyblue
Copy link
Member

No description provided.

@sxzz sxzz changed the title chore: replace typeof with type guard refactor: replace typeof with type guard Jun 10, 2023
sxzz
sxzz approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Jun 10, 2023
@liuseen-l liuseen-l mentioned this pull request Jun 10, 2023
Open
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 87.1 kB (-14 B) 33.1 kB (-3 B) 29.9 kB (+4 B)
vue.global.prod.js 133 kB (-14 B) 50 kB (-7 B) 44.8 kB (-3 B)

Usages

Name Size Gzip Brotli
createApp 48.4 kB 19 kB 17.4 kB
createSSRApp 51.6 kB 20.3 kB 18.5 kB
defineCustomElement 50.7 kB (-14 B) 19.8 kB (-5 B) 18.1 kB (-2 B)
overall 61.7 kB 23.9 kB 21.7 kB

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 20, 2023

CodSpeed Performance Report

Merging #8505 will improve performances by 73.61%

Comparing Alfred-Skyblue:chore-general (1545396) with main (9fa8241)

Summary

⚡ 1 improvements
✅ 52 untouched benchmarks

Benchmarks breakdown

Benchmark main Alfred-Skyblue:chore-general Change
⚡ write reactive obj, read 1000 computeds 68.6 ms 39.5 ms +73.61%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxzz sxzz sxzz approved these changes

Assignees
No one assigned
Labels
ready to merge The PR is ready to be merged.
Projects
Issue / PR Management
Status: Ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Alfred-Skyblue @sxzz