Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v-pre): v-pre more complete static attribute setting #8425

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

baiwusanyu-c
Copy link
Member

close: #8417

@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review May 26, 2023 16:01
# Conflicts:
#	packages/compiler-core/src/parse.ts
#	packages/runtime-core/src/renderer.ts
#	packages/runtime-dom/src/patchProp.ts
Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit a294dee
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/6594c9181530c200082f6375

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit a294dee
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6594c918c1bc2b0008485285

Copy link

github-actions bot commented Jan 3, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 89.6 kB (+133 B) 34.1 kB (+74 B) 30.8 kB (+37 B)
vue.global.prod.js 147 kB (+191 B) 53.4 kB (+62 B) 47.7 kB (+88 B)

Usages

Name Size Gzip Brotli
createApp 50 kB (+133 B) 19.6 kB (+57 B) 17.9 kB (+46 B)
createSSRApp 53.3 kB (+133 B) 20.9 kB (+62 B) 19.1 kB (+67 B)
defineCustomElement 52.2 kB (+133 B) 20.3 kB (+64 B) 18.5 kB (+18 B)
overall 63.4 kB (+133 B) 24.5 kB (+54 B) 22.3 kB (-1 B)

@baiwusanyu-c baiwusanyu-c marked this pull request as draft January 3, 2024 07:25
@baiwusanyu-c baiwusanyu-c marked this pull request as ready for review January 3, 2024 10:00
@skirtles-code
Copy link
Contributor

I think ideally we'd want to implement this in a way that doesn't need explicit support at runtime. I've suggested some possible approaches at #8417 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

v-pre stripping attributes starting with "on-"
2 participants