Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): defineComponent() with generics support #7963

Merged
merged 3 commits into from Mar 27, 2023
Merged

feat(types): defineComponent() with generics support #7963

merged 3 commits into from Mar 27, 2023

Commits on Mar 27, 2023

  1. feat(types): defineComponent() with generics support 

    BREAKING CHANGE: The type of `defineComponent()` when passing in
a function has changed. This overload signature was rarely used in the
past, so it is changed to something more useful.

  Previously the return type was `DefineComponent`, now it is a function
  type that inherits the generics of the function passed in. The
  function passed in as the first argument now also requires a return
  type of a render function, as the signature is no longer meant to be
  used for other use cases.
    @yyx990803
    yyx990803 committed Mar 27, 2023
    Copy the full SHA
    368b6a1 View commit details
    Browse the repository at this point in the history

  2. chore: more tests

    @yyx990803
    yyx990803 committed Mar 27, 2023
    Copy the full SHA
    6ca4b80 View commit details
    Browse the repository at this point in the history

  3. test: add a test for the edge case

    @yyx990803
    yyx990803 committed Mar 27, 2023
    Copy the full SHA
    af96337 View commit details
    Browse the repository at this point in the history