Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): Fixed computed not getting argument types correctly in typescript #5309

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kurorinto
Copy link

@kurorinto kurorinto commented Jan 22, 2022

when I use the computed API in typescript, it not getting argument types correctly.
ec: when I press ‘ge’ , typescript should give a hint of completion

computed({ ge })

I don't know how function types'overload works in typescript, but swap the two computed type expressions definitions in order does works

@netlify
Copy link

netlify bot commented Jan 22, 2022

✔️ Deploy Preview for vue-next-template-explorer ready!

🔨 Explore the source changes: 8bef179

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61ee88a0a702ba0007a2c4c6

😎 Browse the preview: https://deploy-preview-5309--vue-next-template-explorer.netlify.app

@netlify
Copy link

netlify bot commented Jan 22, 2022

✔️ Deploy Preview for vue-sfc-playground ready!

🔨 Explore the source changes: 8bef179

🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61ee88a06e9d6d00084b0964

😎 Browse the preview: https://deploy-preview-5309--vue-sfc-playground.netlify.app/

@netlify
Copy link

netlify bot commented Jan 22, 2022

✔️ Deploy Preview for vuejs-coverage ready!

🔨 Explore the source changes: 8bef179

🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61ee88a0d784c600083c45ea

😎 Browse the preview: https://deploy-preview-5309--vuejs-coverage.netlify.app

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Oct 24, 2024
Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 24, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@5309

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@5309

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@5309

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@5309

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@5309

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@5309

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@5309

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@5309

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@5309

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@5309

vue

pnpm add https://pkg.pr.new/vue@5309

commit: e44c5d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged. scope: types
Projects
Status: Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants