-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reactivity): Fixed computed not getting argument types correctly in typescript #5309
base: main
Are you sure you want to change the base?
Conversation
✔️ Deploy Preview for vue-next-template-explorer ready! 🔨 Explore the source changes: 8bef179 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-next-template-explorer/deploys/61ee88a0a702ba0007a2c4c6 😎 Browse the preview: https://deploy-preview-5309--vue-next-template-explorer.netlify.app |
✔️ Deploy Preview for vue-sfc-playground ready! 🔨 Explore the source changes: 8bef179 🔍 Inspect the deploy log: https://app.netlify.com/sites/vue-sfc-playground/deploys/61ee88a06e9d6d00084b0964 😎 Browse the preview: https://deploy-preview-5309--vue-sfc-playground.netlify.app/ |
✔️ Deploy Preview for vuejs-coverage ready! 🔨 Explore the source changes: 8bef179 🔍 Inspect the deploy log: https://app.netlify.com/sites/vuejs-coverage/deploys/61ee88a0d784c600083c45ea 😎 Browse the preview: https://deploy-preview-5309--vuejs-coverage.netlify.app |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
@vue/compat
vue
commit: |
when I use the computed API in typescript, it not getting argument types correctly.
ec: when I press ‘ge’ , typescript should give a hint of completion
I don't know how function types'overload works in typescript, but swap the two computed type expressions definitions in order does works