Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance the warning when use undeclared variable in template #5010

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/runtime-core/src/componentPublicInstance.ts
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,11 @@ export const PublicInstanceProxyHandlers: ProxyHandler<any> = {
`but is not defined on instance.`,
)
}
} else if (__DEV__ && !__TEST__ && !isReservedPrefix(key[0])) {
warn(
`Property ${JSON.stringify(key)} was accessed during render ` +
`but is not defined on instance.`,
)
}
},

Expand Down
23 changes: 23 additions & 0 deletions packages/vue/__tests__/index.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -311,4 +311,27 @@ describe('compiler + runtime integration', () => {
app.mount(root)
expect(root.innerHTML).toBe('<div>60000000100000111</div>')
})

test('Warning when use undeclared variable in template', () => {
const app = createApp({
template: `
<div @click="handler">handler</div>
<div>dddd{{dddd}}</div>
<div>no warn: {{message}}</div>
`,
setup() {
return {
message: 'hello',
}
},
})
const root = document.createElement('div')
app.mount(root)
expect(
`[Vue warn]: Property "handler" was accessed during render but is not defined on instance.`,
).toHaveBeenWarned()
expect(
`[Vue warn]: Property "dddd" was accessed during render but is not defined on instance.`,
).toHaveBeenWarned()
})
})