Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hmr): avoid hydration for hmr root reload #12450

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Nov 21, 2024

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.9 kB 34.2 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.2 kB 18.3 kB 16.8 kB
createApp 55.2 kB 21.3 kB 19.5 kB
createSSRApp 59.3 kB 23.1 kB 21 kB
defineCustomElement 60.1 kB 22.9 kB 20.8 kB
overall 69.1 kB 26.5 kB 24.1 kB

Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12450

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12450

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12450

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12450

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12450

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12450

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12450

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12450

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12450

vue

pnpm add https://pkg.pr.new/vue@12450

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12450

commit: 750edbd

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: hmr 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Nov 21, 2024
@edison1105 edison1105 requested a review from Copilot November 21, 2024 07:30

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: hmr
Projects
None yet
1 participant