-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ssr): properly init slots during ssr rendering #12441
Open
edison1105
wants to merge
3
commits into
main
Choose a base branch
from
edison/fix/12438
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no suggestions.
edison1105
added
ready to merge
The PR is ready to be merged.
scope: ssr
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
labels
Nov 20, 2024
edison1105
changed the title
fix(ssr): properly handle ssr slot and fallback
fix(ssr): properly init slots during ssr rendering
Nov 20, 2024
@edison1105 just wondering if there is any more work required. From my perspective this looks pretty promising. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
ready to merge
The PR is ready to be merged.
scope: ssr
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #12438
during SSR rendering, the
optimized
parameter passed toinitSlots
is alwaysfalse
. Theslots._
flag is lost wheninitSlots
is called insetupComponent
for the child component. This triggers the logic insidenormalizeObjectSlots
, resulting inslotFn
returning an array that includes a comment node.core/packages/server-renderer/src/helpers/ssrRenderSlot.ts
Lines 59 to 65 in 413c923
related commit 3d34f40#diff-56930a63772d2e89f19432918b9d6ed851ede4159b0d32404e0c1d8c159fec99R1232
SSR rendering does not need to patch slots, so there won't be an issue similar to #10870. Perhaps the
optimized
parameter can always be set to true.