fix(runtime-core): multiple ref elements with the same name #12268
+68
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-sfc
@vue/compiler-dom
@vue/compiler-ssr
@vue/runtime-core
@vue/reactivity
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
edison1105
reviewed
Oct 27, 2024
| refs[ref] = value | ||
| if (canSetSetupRef(ref)) { | ||
| setupState[ref] = value | ||
| if (oldRef !== ref) { |
There was a problem hiding this comment.
I think this solution is OK.
Is it possible to give a warning at runtime?
There was a problem hiding this comment.
Added warning at runtime.
Ensured that recursion does not occur with the Ref or Ref function type, but only with the string.
edison1105
added
🍰 p2-nice-to-have
tsiotska
force-pushed
the
fix-12246_multiple_template_refs
branch
from
718ef90
to
dc1a91e
Compare
tsiotska
force-pushed
the
fix-12246_multiple_template_refs
branch
from
dc1a91e
to
5e273d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #12246
The solution is more like a stub.
Idea is same to keep setting the last ref if multiple same are in template without breaking the code.
Effectively stopped the occurrence of recursion using conditional check
Added appropriate tests.
The best idea would be to set and operate via unique keys and throw a warning in dev mode that ref names should be unique for each element.
Also, would like to cautiously refactor the "if-mess" if the solution is approved.