Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reativity): support for trigger responsive getters in onTrack #12266

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yangxiuxiu1115
Copy link
Contributor

fix #12259
Simply try it.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12266

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12266

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12266

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12266

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12266

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12266

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12266

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12266

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12266

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12266

vue

pnpm add https://pkg.pr.new/vue@12266

commit: 328e9db

@edison1105
Copy link
Member

onTrigger also needs to be handled the same way.

@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. wait changes labels Oct 27, 2024
@yangxiuxiu1115
Copy link
Contributor Author

I didn't find pauseTrigger related logic in the code, or onTrigger just needs pauseTracking related logic too.

@edison1105
Copy link
Member

edison1105 commented Oct 28, 2024

or onTrigger just needs pauseTracking related logic too.

the pauseTracking means that the following codes are not tracking deps. I think pauseTracking needs to be called when onTrigger is executed.

head.sub.onTrigger(

@edison1105 edison1105 added ready to merge The PR is ready to be merged. and removed wait changes labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cant log target.value in onTrack
2 participants