Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vModel): avoid updates caused by side effects of the click #12155

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

re-fix #12144
close #8638
close #8579

Copy link

github-actions bot commented Oct 12, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+282 B) 38 kB (+61 B) 34.2 kB (+87 B)
vue.global.prod.js 159 kB (+282 B) 58 kB (+58 B) 51.5 kB (+65 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

Copy link

pkg-pr-new bot commented Oct 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12155

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12155

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12155

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12155

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12155

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12155

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12155

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12155

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12155

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12155

vue

pnpm add https://pkg.pr.new/vue@12155

commit: fb02ff0

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 12, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 marked this pull request as draft October 12, 2024 04:05
@edison1105 edison1105 marked this pull request as ready for review October 12, 2024 07:00
@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 12, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt failure success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils failure success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 12, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Oct 15, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success failure
nuxt success success
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros success failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the edison/fix/vModel branch October 21, 2024 07:36
@edison1105 edison1105 restored the edison/fix/vModel branch October 21, 2024 08:32
@edison1105 edison1105 reopened this Oct 21, 2024
@edison1105 edison1105 added 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews labels Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready for review This PR requires more reviews
Projects
None yet
2 participants