-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(type): fix nullabe props not getting undefined union #12103
Conversation
Can this be merged @edison1105 ? |
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-ssr
@vue/reactivity
@vue/compiler-sfc
@vue/runtime-core
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
Size ReportBundles
Usages
|
Looks like the type tests are not passing. We also need a test case dedicated for what this intends to fix. |
updated @yyx990803 , @edison1105 |
@@ -94,7 +94,7 @@ export function defineProps() { | |||
} | |||
|
|||
export type DefineProps<T, BKeys extends keyof T> = Readonly<T> & { | |||
readonly [K in BKeys]-?: boolean | |||
readonly [K in BKeys]-?: T[K] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test cases above can pass without this change.
see #12098 (comment)
Will close then, since it's expected |
close #12098
The original implementation didn't carry over the union type