Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): fix nullabe props not getting undefined union #12103

Closed
wants to merge 5 commits into from

Conversation

devTeaa
Copy link

@devTeaa devTeaa commented Oct 3, 2024

close #12098

The original implementation didn't carry over the union type

@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: types labels Oct 3, 2024
@devTeaa
Copy link
Author

devTeaa commented Oct 6, 2024

Can this be merged @edison1105 ?

Copy link

pkg-pr-new bot commented Oct 11, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@12103

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@12103

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@12103

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@12103

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@12103

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@12103

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@12103

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@12103

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@12103

vue

pnpm add https://pkg.pr.new/vue@12103

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@12103

commit: d685cd3

Copy link

github-actions bot commented Oct 11, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.2 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB 26.3 kB 24 kB

@yyx990803 yyx990803 removed the ready to merge The PR is ready to be merged. label Oct 11, 2024
@yyx990803
Copy link
Member

Looks like the type tests are not passing. We also need a test case dedicated for what this intends to fix.

@devTeaa
Copy link
Author

devTeaa commented Oct 11, 2024

updated @yyx990803 , @edison1105

@devTeaa devTeaa changed the title Fix nullabe props not getting undefined union fix(type): fix nullabe props not getting undefined union Oct 15, 2024
@@ -94,7 +94,7 @@ export function defineProps() {
}

export type DefineProps<T, BKeys extends keyof T> = Readonly<T> & {
readonly [K in BKeys]-?: boolean
readonly [K in BKeys]-?: T[K]
Copy link
Member

@edison1105 edison1105 Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cases above can pass without this change.

see #12098 (comment)

@devTeaa
Copy link
Author

devTeaa commented Oct 23, 2024

Will close then, since it's expected

@devTeaa devTeaa closed this Oct 23, 2024
@devTeaa devTeaa deleted the fix-boolean-props-type branch October 29, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nullable boolean props not getting undefined union
3 participants