-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Transition): handle leave immediately done in out-in mode #11824
Open
edison1105
wants to merge
1
commit into
main
Choose a base branch
from
edison/fix/TransitionOnLeave
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edison1105
added
scope: transition
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
labels
Sep 5, 2024
Size ReportBundles
Usages
|
@vue/compiler-sfc
@vue/compiler-dom
@vue/compiler-ssr
@vue/reactivity
@vue/runtime-dom
@vue/runtime-core
@vue/server-renderer
@vue/shared
@vue/compat
vue
@vue/compiler-core
commit: |
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🍰 p2-nice-to-have
Priority 2: this is not breaking anything but nice to have it addressed.
🐞 bug
Something isn't working
scope: transition
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playground
Playground with this PR
This is an edge case. It occurs because
done
is executed immediately inonLeave
, causingafterLeave
to execute immediately, whileemptyPlaceholder
hasn't yet been mounted.While reviewing #4941, I found that #4933 could no longer be reproduced, so I closed them. However, the second issue described in #11061 was previously marked as a duplicate of #4941. #4933 does indeed fix it, but the test cases are not the same. Therefore, I created this new PR.