Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Transition): handle leave immediately done in out-in mode #11824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 5, 2024

Playground
Playground with this PR

This is an edge case. It occurs because done is executed immediately in onLeave, causing afterLeave to execute immediately, while emptyPlaceholder hasn't yet been mounted.

While reviewing #4941, I found that #4933 could no longer be reproduced, so I closed them. However, the second issue described in #11061 was previously marked as a duplicate of #4941. #4933 does indeed fix it, but the test cases are not the same. Therefore, I created this new PR.

@edison1105 edison1105 added scope: transition 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB (+2 B) 38 kB (+2 B) 34.2 kB (+18 B)
vue.global.prod.js 159 kB (+2 B) 57.9 kB (+2 B) 51.5 kB (+15 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.9 kB 18.3 kB 16.7 kB
createApp 55 kB 21.3 kB 19.4 kB
createSSRApp 59 kB 23 kB 20.9 kB
defineCustomElement 59.8 kB 22.8 kB 20.8 kB
overall 68.7 kB (+2 B) 26.3 kB (+1 B) 24 kB (+4 B)

Copy link

pkg-pr-new bot commented Sep 5, 2024

Open in Stackblitz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11824

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11824

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11824

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11824

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11824

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11824

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11824

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11824

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11824

vue

pnpm add https://pkg.pr.new/vue@11824

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11824

commit: 43d5e4d

@edison1105 edison1105 added the 🐞 bug Something isn't working label Sep 5, 2024
@yyx990803
Copy link
Member

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented Sep 5, 2024

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools failure failure
nuxt success failure
pinia success success
primevue success success
quasar success success
radix-vue success success
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n failure success
vue-macros failure success
vuetify success success
vueuse success success
vue-simple-compiler success success

@edison1105 edison1105 closed this Oct 21, 2024
@edison1105 edison1105 deleted the edison/fix/TransitionOnLeave branch October 21, 2024 07:36
@edison1105 edison1105 restored the edison/fix/TransitionOnLeave branch October 21, 2024 08:32
@edison1105 edison1105 reopened this Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. 🐞 bug Something isn't working scope: transition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants