workflow: only verify commit message on main&minor branch #11544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
|
I think it's still nice to enforce consistency since some commits on |
sxzz
commented
Aug 7, 2024
| async function main() { | ||
| const { stdout: branch } = await exec('git', ['branch', '--show-current']) | ||
| // only verify commit message on main and minor branches | ||
| if (branch !== 'main' && branch !== 'minor') { |
There was a problem hiding this comment.
@yyx990803 so, only verify on main and minor branches
There was a problem hiding this comment.
I fully understand the intention behind this PR. However, I want to emphasize that verifying commit messages is not a burden for contributors, as they are already aware of the content of their changes. Additionally, this practice can help them develop good commit habits, which is particularly beneficial in collaborative development with multiple people.
sxzz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For other branches, the commit message is set by the PR title before merging.