-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-sfc): fix type inference issue with the keyof operator #10921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
jh-leong
force-pushed
the
fix/keyof-record
branch
from
May 13, 2024 03:00
d896b67
to
1be162b
Compare
jh-leong
force-pushed
the
fix/keyof-record
branch
from
May 13, 2024 04:12
1be162b
to
3caa0c3
Compare
jh-leong
changed the title
fix(compiler-sfc): handle keyof operator usage w/ Record utility type
[WIP] fix(compiler-sfc): fix type inference issue with the keyof operator
May 13, 2024
jh-leong
changed the title
[WIP] fix(compiler-sfc): fix type inference issue with the keyof operator
fix(compiler-sfc): fix type inference issue with the keyof operator
May 13, 2024
haoqunjiang
added
scope: types
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
labels
May 15, 2024
jh-leong
force-pushed
the
fix/keyof-record
branch
from
May 24, 2024 08:32
30e944b
to
193d65d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
scope: types
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix type inference issue with the
keyof
operator indefineProps
:keyof
with interface index signature correctly.keyof
withRecord
,Partial
,Required
,Readonly
,Pick
,Extract
.keyof
operator, now defaults toUNKNOWN
instead ofString
orObject
. Fixes using symbol as a prop type throw error #10920, fixes Runtime warnings on type of Prop when using keyof and extends since 3.24 #11002.