Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reactivity): change literal flag properties to enum flag properties #10367

Open
wants to merge 3 commits into
base: minor
Choose a base branch
from

Conversation

OnlyWick
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 20, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.5 kB (-31 B) 34.4 kB (-8 B) 31 kB (+6 B)
vue.global.prod.js 148 kB (-31 B) 53.7 kB (-4 B) 47.9 kB (+32 B)

Usages

Name Size Gzip Brotli
createApp 50.7 kB (-21 B) 19.8 kB (-1 B) 18.1 kB (-2 B)
createSSRApp 54 kB (-21 B) 21.1 kB (-1 B) 19.3 kB
defineCustomElement 53 kB (-21 B) 20.6 kB (-1 B) 18.8 kB (+56 B)
overall 64.4 kB (-15 B) 24.8 kB (+4 B) 22.5 kB (-19 B)

@sodatea sodatea added the 🧹 p1-chore Priority 1: this doesn't change code behavior. label Feb 21, 2024
@OnlyWick OnlyWick closed this Feb 24, 2024
@OnlyWick OnlyWick reopened this Feb 25, 2024
@OnlyWick OnlyWick requested a review from sxzz March 1, 2024 07:14
@sxzz
Copy link
Member

sxzz commented Mar 1, 2024

The reactivity system is changed a lot, and related PR is merged into minor branch.

Could you please change the target branch of your PR to minor branch instead of main, then resolve conflicts.

@sxzz sxzz changed the base branch from main to minor March 1, 2024 07:21
@sxzz
Copy link
Member

sxzz commented Mar 1, 2024

I’ve changed it for you. Only one thing you have to be done is rebasing your branch for resolving conflicts and push it directly.

@OnlyWick
Copy link
Contributor Author

OnlyWick commented Mar 1, 2024

I notice that the reactivity system change, does this mean that minor will replace the current version? @sxzz

@sxzz
Copy link
Member

sxzz commented Mar 1, 2024

Yes, minor branch will be merged into main in months and released as v3.5.

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some irrelevant commits, you can run git rebase origin/minor -i to drop.

@OnlyWick OnlyWick force-pushed the reactivity-raw-flags-property-to-enum-property branch from 5ae992a to 42d6207 Compare March 1, 2024 09:06
@OnlyWick OnlyWick requested a review from sxzz March 1, 2024 09:20
@OnlyWick
Copy link
Contributor Author

OnlyWick commented Mar 1, 2024

😥😥 I messed up this PR. Give me a minute.

@sxzz
Copy link
Member

sxzz commented Mar 1, 2024

Hmmm, this PR is a mess. Maybe you can redo it. Try to git reset --hard origin/minor and redo it then commit & force-push.

@OnlyWick OnlyWick force-pushed the reactivity-raw-flags-property-to-enum-property branch from 209a2bd to ee1f7c4 Compare March 1, 2024 10:17
@OnlyWick OnlyWick requested a review from sxzz March 1, 2024 11:22
@OnlyWick
Copy link
Contributor Author

OnlyWick commented Mar 1, 2024

LMAO

@sxzz sxzz added the ready to merge The PR is ready to be merged. label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. ready to merge The PR is ready to be merged. version: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants