feat(runtime-core): restrict setting container for CE

Co-authored-by: 白雾三语 <[email protected]>
vuejs · Sep 23, 2023 · bf0795a · bf0795a
1 parent 9bab0a5
commit bf0795a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/runtime-core/src/component.ts b/packages/runtime-core/src/component.ts
@@ -225,9 +225,9 @@ export interface ComponentInternalInstance {
  root: ComponentInternalInstance
  appContext: AppContext
  /**
- * The DOM element that app is mounted to, or shadowRoot of custom element.
+ * ShadowRoot of custom element if it is
  */
- container: any
+ container: ShadowRoot | null
  /**
  * Vnode representing this component in its parent's vdom tree
  */

diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts
@@ -1201,7 +1201,7 @@ function baseCreateRenderer(
  parentComponent,
  parentSuspense
  ))
- instance.container = container
+ instance.isCE && (instance.container = container as ShadowRoot)
 
  if (__DEV__ && instance.type.__hmrId) {
  registerHMR(instance)

diff --git a/packages/runtime-dom/__tests__/customElement.spec.ts b/packages/runtime-dom/__tests__/customElement.spec.ts
@@ -703,7 +703,7 @@ describe('defineCustomElement', () => {
  const ins = getCurrentInstance()!
  const style = document.createElement('style')
  style.innerHTML = `div { color: red; }`
- ins.container.appendChild(style)
+ ins.container!.appendChild(style)
  return () => h('div', 'hello')
  }
  })