Skip to content

Commit

Permalink
chore(reactivity): correct the description of the test case (#4135)
Browse files Browse the repository at this point in the history
  • Loading branch information
Picknight committed Jul 19, 2021
1 parent 3056e9b commit 35cc7b0
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions packages/reactivity/__tests__/effect.spec.ts
Expand Up @@ -850,7 +850,7 @@ describe('reactivity/effect', () => {
expect(dummy).toBe(1)
})

it('should not be trigger when the value and the old value both are NaN', () => {
it('should not be triggered when the value and the old value both are NaN', () => {
const obj = reactive({
foo: NaN
})
Expand Down Expand Up @@ -884,13 +884,14 @@ describe('reactivity/effect', () => {
expect(record).toBeUndefined()
})

it('should trigger once effect when set the equal proxy', () => {
it('should not be triggered when set with the same proxy', () => {
const obj = reactive({ foo: 1 })
const observed: any = reactive({ obj })
const fnSpy = jest.fn(() => observed.obj)

effect(fnSpy)

expect(fnSpy).toHaveBeenCalledTimes(1)
observed.obj = obj
expect(fnSpy).toHaveBeenCalledTimes(1)

Expand All @@ -900,6 +901,7 @@ describe('reactivity/effect', () => {

effect(fnSpy2)

expect(fnSpy2).toHaveBeenCalledTimes(1)
observed2.obj2 = obj2
expect(fnSpy2).toHaveBeenCalledTimes(1)
})
Expand Down

0 comments on commit 35cc7b0

Please sign in to comment.