Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement v-once #195

Closed
wants to merge 1 commit into from
Closed

Conversation

Jevon617
Copy link
Contributor

@Jevon617 Jevon617 commented Apr 30, 2024

In the process of trying to implement v-once with v-for, v-if, and components, I found that using only variables to handle v-once

for createFor, createIf, and createComponent resulted in highly coupled code. Therefore, in this pull request, I attempted to

use the createOnce function in runtime to handle v-once uniformly. However, I'm not sure if this approach is feasible. If it is,

please provide me with some feedback, thanks.

Demo

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit c4ad155
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/6630bca2b40732000801533b
😎 Deploy Preview https://deploy-preview-195--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for vapor-template-explorer ready!

Name Link
🔨 Latest commit c4ad155
🔍 Latest deploy log https://app.netlify.com/sites/vapor-template-explorer/deploys/6630bca26f36a40008272cfc
😎 Deploy Preview https://deploy-preview-195--vapor-template-explorer.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 80.1 kB 28.2 kB 24.7 kB
compiler-vapor.global.prod.js 52.7 kB (+364 B) 18 kB (+75 B) 16.3 kB (+34 B)
runtime-dom.global.prod.js 94.8 kB 35.7 kB 32.2 kB
runtime-vapor.global.prod.js 45.3 kB (+288 B) 16.9 kB (+77 B) 15.5 kB (+76 B)
vue-vapor.global.prod.js 95.4 kB (+635 B) 33.4 kB (+150 B) 30.2 kB (+170 B)
vue.global.prod.js 152 kB 55 kB 49.2 kB

Usages

Name Size Gzip Brotli
createApp 54.8 kB 21.1 kB 19.2 kB
createSSRApp 58.2 kB 22.4 kB 20.4 kB
defineCustomElement 57.1 kB 21.8 kB 19.9 kB
vapor 45.4 kB (+286 B) 16.9 kB (+84 B) 15.5 kB (+69 B)
overall 68.6 kB 26.1 kB 23.6 kB

Copy link
Member

@sxzz sxzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jevon617
Copy link
Contributor Author

Jevon617 commented May 6, 2024

Okay, thanks.

@Jevon617 Jevon617 closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants